From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: [PATCH 00/10] babel cleanups Date: Mon, 1 Apr 2013 01:42:14 -0400 Message-ID: <1364794944-13826-1-git-send-email-aaronecay@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMXVp-0002is-HN for emacs-orgmode@gnu.org; Mon, 01 Apr 2013 01:42:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMXVn-0000uh-Qj for emacs-orgmode@gnu.org; Mon, 01 Apr 2013 01:42:33 -0400 Received: from mail-qe0-f49.google.com ([209.85.128.49]:56389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMXVn-0000uY-Mm for emacs-orgmode@gnu.org; Mon, 01 Apr 2013 01:42:31 -0400 Received: by mail-qe0-f49.google.com with SMTP id 1so1048249qec.22 for ; Sun, 31 Mar 2013 22:42:31 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Here are several patches to fix things in and around org-babel. They're each independent of the others (and hopefully all apply cleanly, without depending on other members of the series). Here's a little summary of each: Aaron Ecay (10): Fix org-babel-R-initiate-session -> An obvious bugfix Clean up org-babel-expand-body: functions for awk and picolisp -> Makes these functions consistent with other babel languages, though I don't use these languages so can't test Clean up various org-babel-*-maybe commands -> Code simplification and avoids an expensive operation under some circumstances Add 'light argument to some uses of org-babel-get-src-block-info -> Avoids an expensive operation Remove info arg from several org-babel functions -> Code cleanup. Could break third-party code. Use prefix arg in org-edit-special -> Makes the function consistent with its docstring, although the new behavior is somewhat odd (C-u C-c ' becomes basically the same as C-c C-v C-z, AFAICT) Simplify org-babel-execute-src-block -> Makes data flow cleaner through this function Fix testing/lisp/test-ob-emacs-lisp.el -> Obvious bugfix Remove org-babel-check-confirm-evaluate macro -> Refactoring. Of all the patches, I am least sure of this one. It is a complicated operation however you slice it, but I find the approach where the complexity is local easier to understand. Deserves careful review, since it touches code which decides whether to evaluate source blocks. Read: has security implications. Document how :var introduces code block dependencies. -> Documentation. doc/org.texi | 9 +++ lisp/ob-R.el | 20 +++-- lisp/ob-awk.el | 2 +- lisp/ob-core.el | 156 +++++++++++++++++-------------------- lisp/ob-picolisp.el | 2 +- lisp/ob-tangle.el | 2 +- lisp/org.el | 7 +- testing/lisp/test-ob-emacs-lisp.el | 19 +++-- 8 files changed, 112 insertions(+), 105 deletions(-) -- 1.8.2