emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nick Dokos <nicholas.dokos@hp.com>
To: Andreas Leha <andreas.leha@med.uni-goettingen.de>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: Bug in babel eating my text
Date: Wed, 19 Jan 2011 18:54:57 -0500	[thread overview]
Message-ID: <13076.1295481297@gamaville.americas.hpqcorp.net> (raw)
In-Reply-To: Message from Andreas Leha <andreas.leha@med.uni-goettingen.de> of "Wed, 19 Jan 2011 23:52:22 +0100." <4D376B26.1050506@med.uni-goettingen.de>

Andreas Leha <andreas.leha@med.uni-goettingen.de> wrote:

> I found a severe bug that actually eats my text, i.e. *destroys* my
> org-mode file.
> 
> Or am I missing something here?
> 
> Just try that:
> 
> * Test
> 
>   Execute this once:
>   #+BEGIN_src R :session test :results output silent :exports none
>     devnull <- library("tikzDevice")
>   #+END_src
>  
>   Execute this twice or more... but be careful
>   #+BEGIN_src R :session test :results output latex :exports results
>     tikz(console=TRUE, width=4, height=4)
>     plot(1:2,1:2)
>     devnull <- dev.off()
>   #+END_src
> 
> * Watch me die :-(
> 

I can reproduce this: it seems to be eating one character each time it is
executed at the end of the #+END_LaTeX. Here's a patch that seems to fix
this problem - however, it is not based on any real understanding of the code,
so take it with a grain of salt. Also, if this fix works, then it is likely
that the other "wrap" cases will also need similar treatment:

diff --git a/lisp/ob.el b/lisp/ob.el
index 82625c0..2ce57ca 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -1500,7 +1500,7 @@ code ---- the results are extracted in the syntax of the source
 	   ((member "html" result-params)
 	    (wrap "#+BEGIN_HTML\n" "#+END_HTML"))
 	   ((member "latex" result-params)
-	    (wrap "#+BEGIN_LaTeX\n" "#+END_LaTeX"))
+	    (wrap "#+BEGIN_LaTeX\n" "#+END_LaTeX\n"))
 	   ((member "code" result-params)
 	    (wrap (format "#+BEGIN_SRC %s%s\n" (or lang "none") results-switches)
 		  "#+END_SRC"))

HTH,
Nick

next prev parent reply	other threads:[~2011-01-19 23:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 22:52 Bug in babel eating my text Andreas Leha
2011-01-19 23:54 ` Nick Dokos [this message]
2011-01-20 16:32   ` Eric Schulte

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:82625c0 dfblob:2ce57ca
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13076.1295481297@gamaville.americas.hpqcorp.net \
    --to=nicholas.dokos@hp.com \
    --cc=andreas.leha@med.uni-goettingen.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).