emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Lawrence Mitchell <wence@gmx.li>
To: emacs-orgmode@gnu.org
Cc: Lawrence Mitchell <wence@gmx.li>
Subject: [PATCH 2/2] lisp/ob.el: Don't modify babel info when hashing it
Date: Thu,  2 Jun 2011 11:04:05 +0100	[thread overview]
Message-ID: <1307009045-10010-2-git-send-email-wence@gmx.li> (raw)
In-Reply-To: <1307009045-10010-1-git-send-email-wence@gmx.li>

* lisp/ob.el (org-babel-sha1-hash): Don't modify info argument by
side-effect when sorting result-params list.

copy-sequence only does shallow copies, so if we're going to modify a
sub-list, we need to make sure we copy it first.
---
 lisp/ob.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/ob.el b/lisp/ob.el
index e1f4372..36649f0 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -767,7 +767,7 @@ the current subtree."
 				  (cond
 				   ((and (listp v) ; lists are sorted
 					 (member (car arg) '(:result-params)))
-				    (sort v #'string<))
+				    (sort (copy-sequence v) #'string<))
 				   ((and (stringp v) ; strings are sorted
 					 (member (car arg) '(:results :exports)))
 				    (mapconcat #'identity (sort (split-string v)
-- 
1.7.4.1

next prev parent reply	other threads:[~2011-06-02 10:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 10:04 [PATCH 1/2] lisp/ob.el: Fix org-babel-result-regexp to match users Lawrence Mitchell
2011-06-02 10:04 ` Lawrence Mitchell [this message]
2011-06-02 18:22   ` [PATCH 2/2] lisp/ob.el: Don't modify babel info when hashing it Eric Schulte
2011-06-03  8:33     ` Lawrence Mitchell
2011-06-02 18:20 ` [PATCH 1/2] lisp/ob.el: Fix org-babel-result-regexp to match users Eric Schulte

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:e1f4372 dfblob:36649f0
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307009045-10010-2-git-send-email-wence@gmx.li \
    --to=wence@gmx.li \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).