From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: [PATCH] Re: [bug] org-link-escape and (wrong-type-argument stringp nil) Date: Mon, 27 Sep 2010 07:36:00 +0200 Message-ID: <1285565761-7558-1-git-send-email-dmaus@ictsoc.de> References: <8739swi0f0.fsf@gmx.de> Return-path: Received: from [140.186.70.92] (port=33763 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P06No-0004Sh-9t for emacs-orgmode@gnu.org; Mon, 27 Sep 2010 01:36:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P06Nn-0002G5-0M for emacs-orgmode@gnu.org; Mon, 27 Sep 2010 01:36:12 -0400 Received: from mysql1.xlhost.de ([213.202.242.106]:42995) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P06Nm-0002Fx-NA for emacs-orgmode@gnu.org; Mon, 27 Sep 2010 01:36:10 -0400 In-Reply-To: <8739swi0f0.fsf@gmx.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Cc: David Maus > Also I guess the decoding is secure. Means we could change the > comment of this function: > (defun org-protocol-unhex-compound (hex) > "Unhexify unicode hex-chars. E.g. `%C3%B6' is the German Umlaut `รถ'. > Note: this function falls back on single byte decoding if a > character sequence is not valid utf-8. > See `org-protocol-unhex-single-byte-sequence'." > Should I send another patch against master? (Too late here... for > me...) Not necessary, following patch removed this sentence and added a proper commit message (please see: Commit messages and ChangeLog entries on http://orgmode.org/worg/org-contribute.php). I took the new patch "under review" in patchtracker -- If someone else wants to jump on it, just go ahead. Best, -- David Sebastian Rose (1): Decode single byte sequence if decoding unicode failed. lisp/org-protocol.el | 26 +++++++++++++++++++++++--- 1 files changed, 23 insertions(+), 3 deletions(-)