From: David Maus <dmaus@ictsoc.de>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Call `start-process-shell-command' with just 3 arguments.
Date: Thu, 17 Jun 2010 08:44:47 +0200 [thread overview]
Message-ID: <1276757087-23110-2-git-send-email-dmaus@ictsoc.de> (raw)
In-Reply-To: <1276757087-23110-1-git-send-email-dmaus@ictsoc.de>
* org-taskjuggler.el (org-export-as-taskjuggler-and-open):
Call `start-process-shell-command' with 3 arguments.
Passing more than 3 arguments is strongly discouraged. See
docstring of `start-process-shell-command'.
---
lisp/org-taskjuggler.el | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/org-taskjuggler.el b/lisp/org-taskjuggler.el
index f64138e..cb3b079 100644
--- a/lisp/org-taskjuggler.el
+++ b/lisp/org-taskjuggler.el
@@ -326,9 +326,9 @@ defined in `org-export-taskjuggler-default-reports'."
"Export the current buffer as a TaskJuggler file and open it
with the TaskJuggler GUI."
(interactive)
- (let ((file-name (buffer-file-name (org-export-as-taskjuggler)))
- (command "TaskJugglerUI"))
- (start-process-shell-command command nil command file-name)))
+ (let* ((file-name (buffer-file-name (org-export-as-taskjuggler)))
+ (command (concat "TaskJugglerUI " file-name)))
+ (start-process-shell-command command nil command)))
(defun org-taskjuggler-parent-is-ordered-p ()
"Return true if the parent of the current node has a property
--
1.7.1
next prev parent reply other threads:[~2010-06-17 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 6:44 [PATCH] org-taskjuggler.el: Call start-process-shell-command with just 3 arguments David Maus
2010-06-17 6:44 ` David Maus [this message]
2010-06-17 8:58 ` [PATCH] Call `start-process-shell-command' " Christian Egli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276757087-23110-2-git-send-email-dmaus@ictsoc.de \
--to=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).