From mboxrd@z Thu Jan 1 00:00:00 1970 From: James TD Smith Subject: [PATCH] Fix a bug in the remember properties escape Date: Mon, 17 Nov 2008 20:56:26 +0000 Message-ID: <1226955386-17206-1-git-send-email-ahktenzero@mohorovi.cc> Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2B9A-0000tw-Qx for emacs-orgmode@gnu.org; Mon, 17 Nov 2008 15:56:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2B99-0000th-D8 for emacs-orgmode@gnu.org; Mon, 17 Nov 2008 15:56:36 -0500 Received: from [199.232.76.173] (port=44335 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2B99-0000te-7g for emacs-orgmode@gnu.org; Mon, 17 Nov 2008 15:56:35 -0500 Received: from 81-86-40-42.dsl.pipex.com ([81.86.40.42]:64046 helo=yog-sothoth.mohorovi.cc) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L2B98-0006S6-Np for emacs-orgmode@gnu.org; Mon, 17 Nov 2008 15:56:35 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Calling org-property-get-allowed-values with the point not on an item resulted in an error. This patch is available from my git repository, in the branch remember-properties-fix. --- lisp/ChangeLog | 6 ++++++ lisp/org-remember.el | 5 ++++- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 53a21fd..3690659 100755 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,9 @@ +2008-11-17 James TD Smith + + * org-remember.el (org-remember-apply-template): The call to + `org-property-get-allowed-values' failed if the point in the + target file was not on a headline. + 2008-11-17 Carsten Dominik * org-colview.el (org-columns-display-here): New argument diff --git a/lisp/org-remember.el b/lisp/org-remember.el index 5d99ba3..9026489 100644 --- a/lisp/org-remember.el +++ b/lisp/org-remember.el @@ -504,7 +504,10 @@ to be run from that hook to function properly." ((prop (substring-no-properties prompt)) (allowed (with-current-buffer (get-buffer (file-name-nondirectory file)) - (org-property-get-allowed-values nil prop 'table))) + (save-excursion + (if (not (org-at-heading-p)) + (re-search-forward org-complex-heading-regexp)) + (org-property-get-allowed-values nil prop 'table)))) (existing (with-current-buffer (get-buffer (file-name-nondirectory file)) (mapcar 'list (org-property-values prop)))) -- 1.5.6.5