From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [Accepted] Make the latex export preprocessor rewrite #+INDEX to
 \index.
Date: Thu, 5 May 2011 00:36:47 +0200
Message-ID: <11C6FAAE-B0EA-4A93-A85D-6B629BF64000@gmail.com>
References: <1303991243-30731-2-git-send-email-rpgoldman@sift.info>
	<20110504075943.46A1743B538@u016822.science.uva.nl>
	<4DC16BEC.7090609@sift.info>
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:49618)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <carsten.dominik@gmail.com>) id 1QHkgg-0004uP-Gi
	for emacs-orgmode@gnu.org; Wed, 04 May 2011 18:36:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <carsten.dominik@gmail.com>) id 1QHkgf-0005IE-9D
	for emacs-orgmode@gnu.org; Wed, 04 May 2011 18:36:54 -0400
Received: from mail-ey0-f169.google.com ([209.85.215.169]:43494)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <carsten.dominik@gmail.com>) id 1QHkge-0005I7-VQ
	for emacs-orgmode@gnu.org; Wed, 04 May 2011 18:36:53 -0400
Received: by eyd9 with SMTP id 9so549638eyd.0
	for <emacs-orgmode@gnu.org>; Wed, 04 May 2011 15:36:52 -0700 (PDT)
In-Reply-To: <4DC16BEC.7090609@sift.info>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: rpgoldman@sift.info
Cc: Carsten Dominik <cdominik@newartisans.com>, emacs-orgmode@gnu.org


On 4.5.2011, at 17:08, Robert Goldman wrote:

> On 5/4/11 May 4 -2:59 AM, Carsten Dominik wrote:
>> Patch 767 (http://patchwork.newartisans.com/patch/767/) is now =
"Accepted".
>>=20
>> Maintainer comment: Pushed with modifications.  Some optimization, =
and the original patch would have stopped at the first #+index line that =
was missing the entry...  Please verify that it still works
>>=20
>> This relates to the following submission:
>>=20
>> =
http://mid.gmane.org/%3C1303991243-30731-2-git-send-email-rpgoldman%40sift=
.info%3E
>=20
> I think there's a minor problem with the patch.  AFAICT, it binds the
> local variable 'entry' but does not read it (instead it uses the match
> text directly).

That is right, that is unnecessary.  I removed that, thanks.

> As an aside, it might be desirable to handle the empty index case that
> you identified.  E.g.,
>=20
> (if (> (match-end 1) (match-beginning 1))
>    ...rewrite the index entry...
>    ;; else
>    emit a warning
>    rewrite the index entry as the empty string
> )

You mean, instead of ignoring it, there should be an error message
or warning?

- Carsten=