Re: Patch to fix bug where remember template dies w/ non-filename buffer name

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to fix bug where remember template dies w/ non-filename buffer name
Date: Wed, 4 Nov 2009 14:10:43 +0100	[thread overview]
Message-ID: <11BE733E-E199-4E7F-888D-05A734B2393A@gmail.com> (raw)
In-Reply-To: <87ljincc3r.fsf@dustycloud.org>

Applied, thanks.

- Carsten

On Nov 4, 2009, at 2:28 AM, Christopher Allan Webber wrote:

> Hi,
>
> So I ran into an annoying bug where if you have an orgmode remember
> template like:
>
>        ("Test" ?e "* foo \n %^{Bar}p" "~/org/test.org" "Test")
>
> Currently, if either test.org is not open, or test.org is open but the
> buffer is named something else (say, test.org<2>), orgmode will die  
> when
> asking for the property (in this case, Bar).
>
> The issue was that in the org-remember-apply-template function, it  
> would
> attempt to get the buffer like so:
>
>  (get-buffer (file-name-nondirectory file))
>
> in other words, it would try to get the buffer with the name of
> "test.org"... no matter what that buffer was, if exists, or if it was
> even called that.
>
> I've attached a patch that fixes the problem.
>
> Thanks,
> - Christopher Allan Webber
>
> <org-remember-fix.diff>_______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten