From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: [PATCH] org-e-latex: Tables get correct amount of vertical space Date: Tue, 13 Nov 2012 10:56:38 -0500 Message-ID: <11825.1352822198@alphaville> References: <87d2zhr2ym.fsf@gmail.com>, <80a9ulsgdv.fsf@somewhere.org> <87a9ulr19m.fsf@gmail.com> Reply-To: nicholas.dokos@hp.com Return-path: Received: from eggs.gnu.org ([208.118.235.92]:42728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYIqy-0007qj-NA for emacs-orgmode@gnu.org; Tue, 13 Nov 2012 10:56:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYIqv-0008OH-Kz for emacs-orgmode@gnu.org; Tue, 13 Nov 2012 10:56:44 -0500 Received: from g6t0185.atlanta.hp.com ([15.193.32.62]:16419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYIqv-0008O1-Gl for emacs-orgmode@gnu.org; Tue, 13 Nov 2012 10:56:41 -0500 In-Reply-To: Message from Myles English of "Tue, 13 Nov 2012 15:05:57 GMT." <87a9ulr19m.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Myles English Cc: Sebastien Vauban , emacs-orgmode@gnu.org Myles English wrote: > > Hi Seb, > > Sebastien Vauban writes: > > > Hi Myles, > > > > Myles English wrote: > >> This patch replaces every occurence of the \begin{center} environment > >> with \centering in the file contrib/lisp/org-e-latex.el. > >> ... > >> - (format "\\begin{center}\n%s\\end{center}" contents))) > >> + (format "\\centering\n%s" contents))) > > > > Wouldn't you have to replace > > > > \begin{center} > > ... > > \end{center} > > > > by > > > > {\centering > > ... > > } > > > > ? That is, add a group around? > > I don't think so, at least I have not come across that usage, and it > seems to work without. Do you know different? > If a \centering occurs at top-level in a latex document, then *everything* after it will be centered: it's a declaration that remains in force for the current group (which is the rest of the document if it occurs at top-level). \begin{center}...\end{center} is essentially {\centering ...} except that it also starts a new paragraph. It's not clear to me at least, that wholesale replacement is the correct thing to do: it needs to be looked at on a case-by-case basis I think. Nick