From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tom Breton (Tehom)" Subject: Re: org-choose bugfix - whoops Date: Wed, 8 Apr 2009 20:05:17 -0400 (EDT) Message-ID: <1158.66.30.184.144.1239235517.squirrel@mail.panix.com> Mime-Version: 1.0 Content-Type: multipart/mixed;boundary="----=_20090408200517_27583" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lrhli-0005tu-Jb for emacs-orgmode@gnu.org; Wed, 08 Apr 2009 20:05:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lrhle-0005lg-St for emacs-orgmode@gnu.org; Wed, 08 Apr 2009 20:05:22 -0400 Received: from [199.232.76.173] (port=46311 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lrhle-0005lU-Oa for emacs-orgmode@gnu.org; Wed, 08 Apr 2009 20:05:18 -0400 Received: from mail2.panix.com ([166.84.1.73]:56935) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lrhle-0000S5-Au for emacs-orgmode@gnu.org; Wed, 08 Apr 2009 20:05:18 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org ------=_20090408200517_27583 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable My previous fix was mistaken. Not sure why it passed tests; I have two theories. Regardless, it was wrong. Current `(org-outline-level)' seems the correct "LEVEL=3D" matcher argument to make `org-map-entries' find only an item's immediate children. (Operated on by `org-reduced-level' of course) I don't quite understand why. Second, I may have solved the mystery of how the bug got by me before. `org-map-entries' used to place point at the beginning of an item, a fact which I used to recognize visiting the same item. That seems to have changed between org versions. Third, I have fixed the real bug - properly now, I hope! - and attached a patch. Tom Breton (Tehom) ------=_20090408200517_27583 Content-Type: application/octet-stream; name="org-choose.el.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="org-choose.el.diff" Y2QgL2hvbWUvdGVob20vZW1hY3Mtc2l0ZS1saXNwL2J1aWx0L29yZy02LjI1ZC9jb250cmliL2xp c3AvCmRpZmYgLWMgL2hvbWUvdGVob20vZW1hY3Mtc2l0ZS1saXNwL2J1aWx0L29yZy02LjI0Yy9j b250cmliL2xpc3Avb3JnLWNob29zZS5lbCAvaG9tZS90ZWhvbS9lbWFjcy1zaXRlLWxpc3AvYnVp bHQvb3JnLTYuMjVkL2NvbnRyaWIvbGlzcC9vcmctY2hvb3NlLmVsCioqKiAvaG9tZS90ZWhvbS9l bWFjcy1zaXRlLWxpc3AvYnVpbHQvb3JnLTYuMjRjL2NvbnRyaWIvbGlzcC9vcmctY2hvb3NlLmVs CTIwMDktMDQtMDYgMTY6MTE6NDIuMDAwMDAwMDAwIC0wNDAwCi0tLSAvaG9tZS90ZWhvbS9lbWFj cy1zaXRlLWxpc3AvYnVpbHQvb3JnLTYuMjVkL2NvbnRyaWIvbGlzcC9vcmctY2hvb3NlLmVsCTIw MDktMDQtMDggMjA6MDI6MzcuMDAwMDAwMDAwIC0wNDAwCioqKioqKioqKioqKioqKgoqKiogMjM1 LDI0NCAqKioqCiAgICAgCiAgICAgKHVubGVzcwogICAgICAgIDs7U2tpcCB0aGUgZW50cnkgdGhh dCB0cmlnZ2VyZWQgdGhpcyBieSBza2lwcGluZyBhbnkgZW50cnkgd2l0aAohICAgICAgIDs7dGhl IHNhbWUgc3RhcnRpbmcgcG9zaXRpb24uICBCb3RoIG1hcCBhbmQgcGxpc3QgdXNlIHRoZSBzdGFy dAohICAgICAgIDs7b2YgdGhlIGhlYWRlciBsaW5lIGFzIHRoZSBwb3NpdGlvbiwgc28gd2UgY2Fu IGp1c3QgY29tcGFyZQohICAgICAgIDs7dGhlbSB3aXRoIGA9JwohICAgICAgICg9IChwb2ludCkg ZW50cnktcG9zKQogICAgICAgIChsZXQKICAJICgoaXgKICAJICAgICAob3JnLWNob29zZS1nZXQt ZW50cnktaW5kZXgga2V5d29yZHMpKSkKLS0tIDIzNSwyNDggLS0tLQogICAgIAogICAgICh1bmxl c3MKICAgICAgICA7O1NraXAgdGhlIGVudHJ5IHRoYXQgdHJpZ2dlcmVkIHRoaXMgYnkgc2tpcHBp bmcgYW55IGVudHJ5IHdpdGgKISAgICAgICA7O3RoZSBzYW1lIHN0YXJ0aW5nIHBvc2l0aW9uLiAg cGxpc3QgdXNlcyB0aGUgc3RhcnQgb2YgdGhlCiEgICAgICAgOztoZWFkZXIgbGluZSBhcyB0aGUg cG9zaXRpb24sIGJ1dCBtYXAgbm8gbG9uZ2VyIGRvZXMsIHNvIHdlCiEgICAgICAgOztoYXZlIHRv IGdvIGJhY2sgdG8gdGhlIGhlYWRpbmcuCiEgICAgICAgKD0gCiEgCSAoc2F2ZS1leGN1cnNpb24K ISAJICAgIChvcmctYmFjay10by1oZWFkaW5nKQohIAkgICAgKHBvaW50KSkgCiEgCSBlbnRyeS1w b3MpCiAgICAgICAgKGxldAogIAkgKChpeAogIAkgICAgIChvcmctY2hvb3NlLWdldC1lbnRyeS1p bmRleCBrZXl3b3JkcykpKQoqKioqKioqKioqKioqKioKKioqIDI1NiwyNjIgKioqKgogIAogICAg ICh1bmxlc3MKICAgICAgICA7O1NraXAgdGhlIGVudHJ5IHRoYXQgdHJpZ2dlcmVkIHRoaXMuCiEg ICAgICAgKD0gKHBvaW50KSBlbnRyeS1wb3MpCiAgICAgICAgKGxldAogIAkgKChpeAogIAkgICAg IChvcmctY2hvb3NlLWdldC1lbnRyeS1pbmRleCBrZXl3b3JkcykpKQotLS0gMjYwLDI3MCAtLS0t CiAgCiAgICAgKHVubGVzcwogICAgICAgIDs7U2tpcCB0aGUgZW50cnkgdGhhdCB0cmlnZ2VyZWQg dGhpcy4KISAgICAgICAoPSAKISAJIChzYXZlLWV4Y3Vyc2lvbgohIAkgICAgKG9yZy1iYWNrLXRv LWhlYWRpbmcpCiEgCSAgICAocG9pbnQpKQohIAkgZW50cnktcG9zKQogICAgICAgIChsZXQKICAJ ICgoaXgKICAJICAgICAob3JnLWNob29zZS1nZXQtZW50cnktaW5kZXgga2V5d29yZHMpKSkKKioq KioqKioqKioqKioqCioqKiAzOTAsMzk2ICoqKioKICAJICAodW5sZXNzIChvcmctdXAtaGVhZGlu Zy1zYWZlKQogIAkgICAgKGVycm9yICJDaG9vc2luZyBpcyBvbmx5IHN1cHBvcnRlZCBiZXR3ZWVu IHNpYmxpbmdzIGluIGEgdHJlZSwgbm90IG9uIHRvcCBsZXZlbCIpKQogIAkgIChsZXQKISAgCSAg ICAgICgobGV2ZWwgKDErIChvcmctcmVkdWNlZC1sZXZlbCAob3JnLW91dGxpbmUtbGV2ZWwpKSkp KQogIAkgICAgKHNhdmUtcmVzdHJpY3Rpb24KICAJICAgICAgKG9yZy1tYXAtZW50cmllcyAKICAJ ICAgICAgIGZuCi0tLSAzOTgsNDA0IC0tLS0KICAJICAodW5sZXNzIChvcmctdXAtaGVhZGluZy1z YWZlKQogIAkgICAgKGVycm9yICJDaG9vc2luZyBpcyBvbmx5IHN1cHBvcnRlZCBiZXR3ZWVuIHNp YmxpbmdzIGluIGEgdHJlZSwgbm90IG9uIHRvcCBsZXZlbCIpKQogIAkgIChsZXQKISAgCSAgICAg ICgobGV2ZWwgKG9yZy1yZWR1Y2VkLWxldmVsIChvcmctb3V0bGluZS1sZXZlbCkpKSkKICAJICAg IChzYXZlLXJlc3RyaWN0aW9uCiAgCSAgICAgIChvcmctbWFwLWVudHJpZXMgCiAgCSAgICAgICBm bgoKRGlmZiBmaW5pc2hlZCBhdCBXZWQgQXByICA4IDIwOjAyOjU0Cg== ------=_20090408200517_27583 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode ------=_20090408200517_27583--