From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: partial-completion-mode error when refiling Date: Thu, 30 Jun 2011 08:40:40 -0400 Message-ID: <11283.1309437640@alphaville.dokosmarshall.org> References: <80y60j4u4z.fsf@somewhere.org> <87sjqrk7fo.fsf@gnu.org> Reply-To: nicholas.dokos@hp.com Return-path: Received: from eggs.gnu.org ([140.186.70.92]:47581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcGY7-0007Uf-DM for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 08:40:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcGY5-00077T-NB for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 08:40:51 -0400 Received: from vms173005pub.verizon.net ([206.46.173.5]:54972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcGY5-00077E-9X for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 08:40:49 -0400 Received: from alphaville.dokosmarshall.org ([unknown] [173.76.32.106]) by vms173005.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LNL004IGSJSZCC0@vms173005.mailsrvcs.net> for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 07:40:47 -0500 (CDT) In-reply-to: Message from Bastien of "Thu, 30 Jun 2011 11:14:03 +0200." <87sjqrk7fo.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Sebastien Vauban , nicholas.dokos@hp.com, emacs-orgmode@gnu.org Bastien wrote: > Hi Sebastian, > > "Sebastien Vauban" writes: > > > When I was trying to refile an extract of an email, I got this: > > > > Getting targets...done > > funcall: Symbol's function definition is void: partial-completion-mode > > thanks for reporting this -- this is indeed something wrong with the fix > I made to `org-without-partial-completion' (see my other message to Paul > Sexton). > > I reverted his patch so you won't see this error again. > I'm not sure that't the problem though: the org-without-partial-completion macro is called in a couple of places, once in org-remember.el and twice in org.el. I'm not sure how many people still use org-remember, but I suspect quite a few. The macro basically says: execute the body while mmaking sure that partial-completion-body is off during the execution. At least, that's the intent but I haven't thought through the quoting change that Paul made. The calls: o org-remember-apply-template: called in the g or G case to complete tags. o org.el: in org-icompleting-read. o org.el: in org-set-tags *around* org-icompleting-read. The last one seems superfluous at first sight, but I haven't thought about it yet. In any case, these seem fairly common situations so I think it is likely that the macro has been called hundreds of times (over the whole org population) without ill effects. OTOH, partial-completion-mode is called explicitly in org-refile-get-location, like this: (partial-completion-mode nil) Could it be that it is really meant to turn *off* partial completion mode? In which case, it would be better to call the org-without-partion-completion macro here to do the work. In any case, this explicit call seems to be more problematic than the macro. After all that's what Seb hit. Nick