From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YD6HEaPY42LzYgEAbAwnHQ (envelope-from ) for ; Fri, 29 Jul 2022 14:54:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uAaAEaPY42LGbAEAauVa8A (envelope-from ) for ; Fri, 29 Jul 2022 14:54:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE937428B1 for ; Fri, 29 Jul 2022 14:54:58 +0200 (CEST) Received: from localhost ([::1]:35754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHPW5-0003lW-Sc for larch@yhetil.org; Fri, 29 Jul 2022 08:54:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHPVI-0003js-LH for emacs-orgmode@gnu.org; Fri, 29 Jul 2022 08:54:08 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:42954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHPVG-0006BS-UO for emacs-orgmode@gnu.org; Fri, 29 Jul 2022 08:54:08 -0400 Received: by mail-lf1-x12c.google.com with SMTP id p10so7151688lfd.9 for ; Fri, 29 Jul 2022 05:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ifdg0Ub7X8MKDino9t36njQ8chrJ6gNvSdiVM+G6+yg=; b=LzxfvUmppVHHtV7kSlYE0qJ+NKFVXXDn111+gaswi4ik9kPyny3MMyDTInYlhponOx F1kKkw4w27XsXECs43v7UBPkb+ESqiv5pVja77Mt5hVseypEyKZLnq/pX/rNGhaxIx85 MQxlyc4fp7p6dlnq9k7T3jnQvn221PA+xcseoxLVjgOQ/Zp9SF/1VKOC6HwbA1X2JiJ8 7sMwYv2ULlhqJ/bpBz9k28e9ndzITvG/qXUeaJG8tNd4W/8UzPI/akW8PHitn0w3RAlf n141oxhy5hikci9iYrdGaZijxWpiBu8ZVgr206Ick73EG+tfye6OHHYJt7bSwxsVn6Ql DqSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ifdg0Ub7X8MKDino9t36njQ8chrJ6gNvSdiVM+G6+yg=; b=h0va+28DhZrJRLjG3l5LzPFC0Mk4J4Yh8C6UMbRgSWtRxNlaYNlknWmUW5eiYe8CEX WDMVOgnuP8/Iil5xHM7aPn439BMgPFfyn6WloUO9vk7Ax3j5MnhO1zybVsUItgKcp6x0 b1+D4+qttkqM8ybrJhEJfR7NS6xkUROTVWiJmiiCa2LPmTlHNGK5xOYNrZrlhxswUNEV SG0mEBLAcDlJK1ilnaxR2awrV6nn8/5UczbHge8IBt4fcl+bCSM09CZTiE13Sh2Wyclz KzwhEFqRpZ6aDIfIbYGvZYaUDz+0B2OkSFtjUmc2rWMVwIhW3WtNO5s/CpCZl+3L8jtg aaUw== X-Gm-Message-State: AJIora+hTE+cTpIZd0A7Ehk0Xcjj+b0NYdwuNdrxEwgpdhCjRLbMdXqZ MhdjfBomel9NYBxO3EjKU6M= X-Google-Smtp-Source: AGRyM1v/xN12Hc5QYJV1p7ahff9eB5huwTrvXPKYDRRd20LMuV/ndbzGkw+ddPfULz8Vbwz70RBoFg== X-Received: by 2002:a05:6512:2185:b0:482:b4f0:f23 with SMTP id b5-20020a056512218500b00482b4f00f23mr1330497lft.31.1659099244246; Fri, 29 Jul 2022 05:54:04 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id bg11-20020a05651c0b8b00b0025e2e70b41fsm645736ljb.71.2022.07.29.05.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 05:54:02 -0700 (PDT) Message-ID: <0da49392-26c6-8ba3-f657-647522d59342@gmail.com> Date: Fri, 29 Jul 2022 19:54:00 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8] ol.el: add description format parameter to org-link-parameters Content-Language: en-US To: Hugo Heagren Cc: emacs-orgmode@gnu.org References: <87zgl1npow.fsf@localhost> <20220405192931.6747-1-hugo@heagren.com> <87a6cx79xn.fsf@localhost> <87zgi6fckr.fsf@heagren.com> <871qvixhfw.fsf@gmail.com> <87v8s8n1bm.fsf@heagren.com> <87let39d3c.fsf@localhost> <877d4flu3x.fsf@heagren.com> <87cze5e84m.fsf@localhost> <87tu7gkb4l.fsf@heagren.com> <87y1ws6o0c.fsf@localhost> <87k08bjw0t.fsf@heagren.com> <47248a4f-10aa-0980-c054-563f30c05aaa@gmail.com> <87mtd0gthe.fsf@heagren.com> <78b97c9e-fced-0ee4-f3f2-3cbe81080ffa@gmail.com> <87sfms9dx7.fsf@localhost> <87v8rmd53g.fsf@localhost> <871qu9xv8q.fsf@heagren.com> From: Max Nikulin In-Reply-To: <871qu9xv8q.fsf@heagren.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=manikulin@gmail.com; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659099298; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ifdg0Ub7X8MKDino9t36njQ8chrJ6gNvSdiVM+G6+yg=; b=jOXfBIou94OpcmGVz2zALGY3LmgqzOc95m8FKsCrkGXodyekPr0MB/WEFuYVIzX481q7uz QD5DDILIufyE6oKlLx+1SYbC37fvihNdCTAIifCVZoc3mPDo5Qlv+ozFmEIEUK4mmmsylC wDMLgC2nDHjdh00AwWoYsJ+aFUfEQ6ueAPUA6WtnWl37sK7z4+vC+/tbb2wkT2f+OLnxQb NwvejMxPnFY2jrn0NG4R4HNZdGrhKTdfqhdee+UqAy1DOhACV1QavEpnY6DubBHMo/eXCc eU+fEPVDBxaK1lHHN58BXYSameAJbhxVI50NOz0tpMEiMbzNwLZ51hrq2SlmnQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659099298; a=rsa-sha256; cv=none; b=PPDvyy+8YOuP4+rDIUDuWOWYJ+fvig8M22yoGfNaxaKk2/TMoMhstx4xg/Z4LQ8QuECgRE fcGMcMm8IVZ+D6VboHa6Qja6/oMexFgK+C9U0IT1+DYyvuVU3xJ+NlN4a1dilMidmSVSBy Q97ZDxctAYW1YoqU3ycPVf8yL+Ced3yD0NUn/pvoEt5aw7s6TxbVCYb9b8wVf9CQKuDZa2 RQ1jmGX5ew25fMRMn+Z496epGeT0cDDkNnQRp17YjrW7DHHP7iWK3JBxcDDbR9LAyRNhf3 NNBBYECpB6/AWDUQZhgFbBaDI6PREwZlC0xTDM41JZqABpiccDBelqYccUrhaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LzxfvUmp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.28 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LzxfvUmp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DE937428B1 X-Spam-Score: 7.28 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1scZ9AxnS/ul On 25/07/2022 18:55, Hugo Heagren wrote: >> In any case, we cannot, unfortunately, use map-do here and should >> probably fall back to the previous version with cl-loop. > > You're right, this is strange. Oh well, I've moved back to the version > of the macro which used `cl-loop' in the current patch. Nothing else > is changed. All the tests pass for me. Hugo, almost certainly you are tired by so many iterations, but I still can not approve your patch. It is again Emacs-26 and likely the last `should' form with (org-link-parameters nil). I hope, you have not lost motivation yet and you will fix this test failure. Test test-ol/insert-link-insert-description backtrace: signal(error ("rx form ‘or’ requires at least 1 args")) apply(signal (error ("rx form ‘or’ requires at least 1 args"))) (setq value-7590 (apply fn-7588 args-7589)) (unwind-protect (setq value-7590 (apply fn-7588 args-7589)) (setq fo (if (unwind-protect (setq value-7590 (apply fn-7588 args-7589)) (set (let (form-description-7592) (if (unwind-protect (setq value-7590 (a (let ((value-7590 (quote ert-form-evaluation-aborted-7591))) (let (f (let* ((fn-7588 (function null)) (args-7589 (condition-case err (let (closure (t) nil (let* ((fn-7563 (function string=)) (args-7564 (con ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-ol/insert-link-insert-descriptio ert-run-or-rerun-test(#s(ert--stats :selector "test-ol/" :tests [#s( ert-run-tests("test-ol/" #f(compiled-function (event-type &rest even ert-run-tests-batch("test-ol/") ert-run-tests-batch-and-exit("test-ol/") (let ((org-id-track-globally t) (org-test-selector (if org-test-sele org-test-run-batch-tests("test-ol/") eval((org-test-run-batch-tests org-test-select-re)) command-line-1(("--eval" "(setq vc-handled-backends nil org-startup- command-line() normal-top-level() Test test-ol/insert-link-insert-description condition: (error "rx form ‘or’ requires at least 1 args") FAILED 5/13 test-ol/insert-link-insert-description