From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EPj3E6a6j2GKHgEAgWs5BA (envelope-from ) for ; Sat, 13 Nov 2021 14:16:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2CmoD6a6j2FBWAAA1q6Kng (envelope-from ) for ; Sat, 13 Nov 2021 13:16:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0FD62BAEE for ; Sat, 13 Nov 2021 14:16:21 +0100 (CET) Received: from localhost ([::1]:44508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlstH-0006Uj-Fp for larch@yhetil.org; Sat, 13 Nov 2021 08:16:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlssK-0006Rn-Lj for emacs-orgmode@gnu.org; Sat, 13 Nov 2021 08:15:20 -0500 Received: from [2a00:1450:4864:20::132] (port=36468 helo=mail-lf1-x132.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlssI-0001Wj-Ix for emacs-orgmode@gnu.org; Sat, 13 Nov 2021 08:15:20 -0500 Received: by mail-lf1-x132.google.com with SMTP id k37so29635796lfv.3 for ; Sat, 13 Nov 2021 05:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aHuEBR28fgC8/bO+LEShbIHCSwLXV0PvFkgiSDb0roo=; b=GBmfGiwfNgy/0xSiDlT4kf6OBopRNJmAspqKGGhcGpGoZIo+eOwkYyDd8mDD/ZyO3H x8JTG3rTvGiZPlFnyXeyijuU6p796GcdnD0q+JEVqgaQervpNEcznAt/6kDs+hY0Gcsy j98Zlwch6onCZGwE571sKJ+VUpirrtY3UxLmTM4dMZGmnkBFJGHz/U2fgPcSKtb5ImUm zplmrEmZDcU3BMiDj9Tjb5YuuJ1bHvjYJsvvGY1aeOmseQvBbgaU7G3kxF7ggK01MhY4 okEon9r3t+qjLBtukdtSuHxMxFuGiexoFHmuiwGit/zKqkJ/4W6MMEZkr8SkHS7Cu3TW ieog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aHuEBR28fgC8/bO+LEShbIHCSwLXV0PvFkgiSDb0roo=; b=NaWBJR+UjXnOE+h7D3kd1HxK450CJJJnwqXkUvTB7elclqWVQWOvIEsUynOQ0TLTna MzSOY58+5EtK+Fvi5GfuJ59hnjFlymj+3Wyz9BXsLDsUFUkt9GEzvzkVIdn6iK5jlp63 KgjJ6qxTaxC7mgDXaNrNvmXenaArKCn5VwJ2rWP6LyNHSDa2+l/OSALZiV3Y0RayYxzH fvTNGuvORA3YenG8u6PFDszy7ywm/Etu5rLJrwkIXgOuWgJqFgO5YsUMm0AUnJpfLQZ4 qJi+PE4QVLvfILpVHbPkQVWaJkGCbQQ1OLo14l/j5pYAwjV78juz92zfuS/4p1nV4FI+ mbtQ== X-Gm-Message-State: AOAM530ss1YybAy2u63W+dSuv8n0wM51Xcj0SkIxHgENqkc8oDI4iRcs 55L2hEYscd3GB3MbX5YQ+Kl5vp01ADM= X-Google-Smtp-Source: ABdhPJxUpkmQJh4das8XU374+BDxOYeLwynFbydg27Q169lMCJnvza3BI6LKgWDrVZbxUUe8Nh/CAA== X-Received: by 2002:a05:6512:3410:: with SMTP id i16mr20815862lfr.113.1636809313104; Sat, 13 Nov 2021 05:15:13 -0800 (PST) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id b12sm866798lfv.91.2021.11.13.05.15.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Nov 2021 05:15:12 -0800 (PST) From: Max Nikulin Subject: Re: Bug: org-no-popups disregards display-buffer-fallback-action 9.4.6 To: Jan Seeger , emacs-orgmode@gnu.org References: <87a6ic5u1c.fsf@dumper.i-did-not-set--mail-host-address--so-tickle-me> Message-ID: <06bed7f3-4f31-4d66-4314-18c08c8dbb34@gmail.com> Date: Sat, 13 Nov 2021 20:15:11 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87a6ic5u1c.fsf@dumper.i-did-not-set--mail-host-address--so-tickle-me> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::132 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::132; envelope-from=manikulin@gmail.com; helo=mail-lf1-x132.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.852, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636809381; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=aHuEBR28fgC8/bO+LEShbIHCSwLXV0PvFkgiSDb0roo=; b=K9Q31urFe0w7YphshpEm00ilSi9XuY6dYJe+GBHPfJRe3EkiV12aTojwNUNrlQSxQBTuC4 tNSrDW1D4jHM6pIsSKlKDxJz8y5JNIaTFfDIACeSKdYEc40iLFub1NVJIjiRUlp4pG9JdI 41AUxu2+/R+VwIIWvCGLFtnW+65ULyiLlddZSznR6pMcko0yQIGxsvcbnCKhywRkbdCQC0 zljvh5+30nEN8lVEY47+KippqlfGw4NCU0wqqv6FTrR0ufCIwyowcJzs7LRD4go9OvzvKW 2/pCeJhpj5oS3LHrz270ueqd3v8AeQ1esR+chAzOdm2iB/O/NyDBcfTlrxLP/Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636809381; a=rsa-sha256; cv=none; b=Uqh3DId6dbetnV7vnEsqaely/k3bkMQCsMvtd7NSHKZdzYFdgQVsbYVWGOOb+X7i7GvqsU XcOtP5bmkeWCyEUE1zOMIFlagFlhNdIeE2nbH4FDzcmboNyshSJ7fwn2Zm2GIRxT8nJSwz CMCSFwS6VD1YEASLkwY8gFcRVdHPEXh0h30v6m867Ll2oPTf9srBgZ3RFsM4er1oy+o5qp MScD4wRFwVlByMTQCGLse3mfzlpf9UlMYHjiVr/d8RdpV+I61DyEqVHFg9wTnJfsP2tg0c YiI6IRl1c4RMoCXkO969XGVAJCs3JDfGezV9zKYFN3dVPMQhlYA/cCb+oIk6PQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=GBmfGiwf; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.47 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=GBmfGiwf; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D0FD62BAEE X-Spam-Score: 1.47 X-Migadu-Scanner: scn0.migadu.com X-TUID: zgOL9l3r3+OB On 10/11/2021 14:50, Jan Seeger wrote: > > I'm trying to make multi-frame emacsing nicer, and I encountered what I > consider a bug with the `org-no-popups` macro in `org-macs.el`. > > `org-no-popups` tries to surpress the creation of new frames via setting > `pop-up-frames` and `display-buffer-alist` to nil temporarily. This does > not take `display-buffer-fallback-action` into account, which is the > preferred way of making Emacs pop up new frames (or not, as the case may > be). When the fallback variable is set, code run inside `org-no-popups` > still creates new popups, which causes functions such as > `org-insert-link` to fail, or at least act *very* confusingly. > > The preferred way of overriding the behavior of `display-buffer` for > localized Emacs code seems to be the variable > `display-buffer-overriding-action`. > > Changing the definition of `org-no-popups` to > > ``` > (defmacro org-no-popups (&rest body) > "Suppress popup windows and evaluate BODY." > `(let ((display-buffer-overriding-action '(display-buffer-pop-up-window))) > ,@body)) > ``` > > correctly makes org pop up windows instead of frames. There were enough threads concerning displaying of buffers in Org, e.g. https://list.orgmode.org/87mtnovv7f.fsf@alphapapa.net https://list.orgmode.org/87zgrgke4b.fsf@ucl.ac.uk Some users prefers multiple frames, others multiple windows in a full-screen frame. Could you, please, briefly describe what kind of behavior you are truing to achieve? Overriding `display-buffer-alist' was certainly a mistake, users should be able to customize window creation. My impression is that `org-no-popups' is used in different scenarios that should have different default behavior. Some Org buffers, in my opinion, should behave similarly to completion list. On the other hand `minibuffer-completion-help' does not use `display-buffer-overrining-action'. I do not like that this variable has higher priority than `display-buffer-alist'. Action argument of `display-buffer' is more appropriate since it keeps ability to customize placement of buffers with particular names through `display-buffer-alist'. Thank you for suggesting `display-buffer-pop-up-window', current way of suppressing pop-up frames is unreliable. I am considering another option: '(nil (inhibit-switch-frame . t)) and I am unsure which variant is better. Actually I can not say that I really understand supposed ways to use `display-buffer' and related functions. My original expectation was that emacs should have a high level function for buffers similar to "*Completions*".