From: Max Nikulin <firstname.lastname@example.org> To: Jan Seeger <email@example.com>, firstname.lastname@example.org Subject: Re: Bug: org-no-popups disregards display-buffer-fallback-action 9.4.6 Date: Sat, 13 Nov 2021 20:15:11 +0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 10/11/2021 14:50, Jan Seeger wrote: > > I'm trying to make multi-frame emacsing nicer, and I encountered what I > consider a bug with the `org-no-popups` macro in `org-macs.el`. > > `org-no-popups` tries to surpress the creation of new frames via setting > `pop-up-frames` and `display-buffer-alist` to nil temporarily. This does > not take `display-buffer-fallback-action` into account, which is the > preferred way of making Emacs pop up new frames (or not, as the case may > be). When the fallback variable is set, code run inside `org-no-popups` > still creates new popups, which causes functions such as > `org-insert-link` to fail, or at least act *very* confusingly. > > The preferred way of overriding the behavior of `display-buffer` for > localized Emacs code seems to be the variable > `display-buffer-overriding-action`. > > Changing the definition of `org-no-popups` to > > ``` > (defmacro org-no-popups (&rest body) > "Suppress popup windows and evaluate BODY." > `(let ((display-buffer-overriding-action '(display-buffer-pop-up-window))) > ,@body)) > ``` > > correctly makes org pop up windows instead of frames. There were enough threads concerning displaying of buffers in Org, e.g. https://email@example.com https://firstname.lastname@example.org Some users prefers multiple frames, others multiple windows in a full-screen frame. Could you, please, briefly describe what kind of behavior you are truing to achieve? Overriding `display-buffer-alist' was certainly a mistake, users should be able to customize window creation. My impression is that `org-no-popups' is used in different scenarios that should have different default behavior. Some Org buffers, in my opinion, should behave similarly to completion list. On the other hand `minibuffer-completion-help' does not use `display-buffer-overrining-action'. I do not like that this variable has higher priority than `display-buffer-alist'. Action argument of `display-buffer' is more appropriate since it keeps ability to customize placement of buffers with particular names through `display-buffer-alist'. Thank you for suggesting `display-buffer-pop-up-window', current way of suppressing pop-up frames is unreliable. I am considering another option: '(nil (inhibit-switch-frame . t)) and I am unsure which variant is better. Actually I can not say that I really understand supposed ways to use `display-buffer' and related functions. My original expectation was that emacs should have a high level function for buffers similar to "*Completions*".
next prev parent reply other threads:[~2021-11-13 13:16 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-10 7:50 Bug: org-no-popups disregards display-buffer-fallback-action [9.4.6 (9.4.6-13-g4be129-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)] Jan Seeger via General discussions about Org-mode. 2021-11-10 10:20 ` Ihor Radchenko 2021-11-13 17:34 ` dal-blazej 2021-11-14 6:08 ` Ihor Radchenko 2021-11-14 12:13 ` Eric S Fraga 2021-11-14 12:40 ` Ihor Radchenko 2021-11-14 19:37 ` Eric S Fraga 2021-11-14 23:03 ` dal-blazej 2021-11-15 9:57 ` Eric S Fraga 2021-11-15 16:54 ` org-capture windows Max Nikulin 2021-11-15 18:29 ` Eric S Fraga 2021-11-15 19:40 ` Bug: org-no-popups disregards display-buffer-fallback-action [9.4.6 (9.4.6-13-g4be129-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)] Daniel Kraus 2021-11-15 7:41 ` Jan Seeger via General discussions about Org-mode. 2021-11-13 13:15 ` Max Nikulin [this message] 2021-11-15 7:42 ` Bug: org-no-popups disregards display-buffer-fallback-action 9.4.6 Jan Seeger via General discussions about Org-mode. 2021-11-15 7:49 ` Jan Seeger via General discussions about Org-mode. 2021-11-17 14:49 ` Max Nikulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Bug: org-no-popups disregards display-buffer-fallback-action 9.4.6' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).