emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Louis Gostiaux <louis.gostiaux@free.fr>
To: Kyle Meyer <kyle@kyleam.com>,
	Pablo Palazon <pablo.palazon@gmail.com>,
	emacs-orgmode@gnu.org
Cc: "Thomas S. Dye" <tsd@tsdye.online>
Subject: Re: [PATCH] Add margin option to float for figure in ox-latex.el
Date: Sat, 16 May 2020 09:17:07 +0200	[thread overview]
Message-ID: <027854c0-c210-5305-a9cc-d07f124df1de@free.fr> (raw)
In-Reply-To: <87o8qoqtau.fsf@kyleam.com>

Hi all,

Kyle could you please redirect also to Pablo's patch ? Couldn't find it.

That's also great that an exporter for tufte exists. However, as far as 
I understood, marginfigure is not exclusevely usedby tufte. I guess the 
marginfigure environment coule be supported in the generic latex export, 
and the tufte export could simply focus on the environments specific to 
tufte ?

That's great you found my post. At the time Bastien Guerry had replied, 
but no news since then.

Louis.

Le 16/05/2020 à 08:37, Kyle Meyer a écrit :
> Pablo Palazon writes:
>
>> I've created a path to add a new option to float properties for figures on
>> latex. This is my first change for org-mode, and I don't really sure if
>> this is the correct way to do it.
> Thank you!
>
>> * lisp/ox-latex.el (org-latex--inline-image): Include margin option
>> to create marginfigure environment for figures. It's useful for tufte
>> latex class, where with this environment shows the figure in the margin.
> I wondered if something like this had been proposed or discussed before.
> Searching the list, I see a patch [0] very similar to yours from a
> couple of months back that didn't get a response (author added to cc).
>
> Further back, there is a thread about an exporter Thomas Dye (+cc) wrote
> to handle marginfigure and some other Tufte-y things [1].  It looks like
> the code is available at <https://github.com/tsdye/tufte-org-mode>,
> though I'm not sure if it still works with the current Org.
>
> As for the proposed patch, while I think the specific code change itself
> looks fine, skimming through the above thread makes me think that adding
> marginfigure to ox-latex.el without considering similar cases may not be
> the right approach.  What do others think?
>
>
> [0]: https://yhetil.org/orgmode/35aac187-b751-5723-0f15-be6605fb8ea2@free.fr/
> [1]: https://yhetil.org/orgmode/m2h9hsgdo2.fsf@tsdye.com/


  reply	other threads:[~2020-05-16  7:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 16:06 [PATCH] Add margin option to float for figure in ox-latex.el Pablo Palazon
2020-05-15 12:21 ` Eric S Fraga
2020-05-15 17:02   ` Pablo Palazon
2020-05-16  6:37 ` Kyle Meyer
2020-05-16  7:17   ` Louis Gostiaux [this message]
2020-05-16 16:46     ` Kyle Meyer
2020-05-16 18:00   ` Thomas S. Dye
2020-05-16 20:35     ` Kyle Meyer
2020-05-17 16:48       ` Thomas S. Dye
2020-05-23  9:12         ` Bastien
     [not found] <mailman.39.1589558407.15748.emacs-orgmode@gnu.org>
2020-05-15 16:47 ` Pablo Palazon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=027854c0-c210-5305-a9cc-d07f124df1de@free.fr \
    --to=louis.gostiaux@free.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    --cc=pablo.palazon@gmail.com \
    --cc=tsd@tsdye.online \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).