From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WDg+IlWClGBaHgAAgWs5BA (envelope-from ) for ; Fri, 07 May 2021 01:57:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0MvSHVWClGA0cwAAB5/wlQ (envelope-from ) for ; Thu, 06 May 2021 23:57:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E4589C6F for ; Fri, 7 May 2021 01:57:09 +0200 (CEST) Received: from localhost ([::1]:60908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lenrf-0005bX-39 for larch@yhetil.org; Thu, 06 May 2021 19:57:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lenrB-0005bD-09 for emacs-orgmode@gnu.org; Thu, 06 May 2021 19:56:37 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lenr9-0007sq-8E for emacs-orgmode@gnu.org; Thu, 06 May 2021 19:56:36 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B60B65C005D for ; Thu, 6 May 2021 19:56:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 06 May 2021 19:56:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=cn35AZTfxo91VH0rwlr2sJ4eVRZHJHdWdrKSkJrSl zM=; b=PXqdejepH8g8GDFb7zfkv7B6T7G3TxXPl5JUhUGyR81ivIXCK5Jav9EfW wka+Gy+YE5OZDZdFv8n7qabdfaba/mHwoI4ojx/J0KblfmlZ374PQlNEmqpRq0kz RtCPezWveo9xsBicAJc1eR+izGl9ms9uKaS4yeyBwucDrQAY2VCJfPgearfhzlhA VFSPsuRRd1XDpGgauH6rXREDk6qHokY2kf1APwxPEWUfBeBh0V81gsiWlhNM8Wp0 u006ukV5YW0DGEiRTQ48rAAewJvjvXG8rTpfmkJbCdP0LhpdU3wpCO9mH/0CzI2K oh+uu93zNp198V/Jnn35Z0sUTSwew== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeguddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvfhfhffkffgfgggjtgfgsehtje ertddtfeehnecuhfhrohhmpefpihgtkhcuufgrvhgrghgvuceonhhitghksehnihgtkhhs rghvrghgvgdrtggrqeenucggtffrrghtthgvrhhnpeeludekuddtgfejjefhfefhledvfe effeevuedtgfeileeffedvkeevvefhveelleenucfkphepjeeirdeijedrudekuddrgeeh necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepnhhitg hksehnihgtkhhsrghvrghgvgdrtggr X-ME-Proxy: Received: from [192.168.0.67] (bras-base-aylmpq0104w-grc-29-76-67-181-45.dsl.bell.ca [76.67.181.45]) by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 6 May 2021 19:56:33 -0400 (EDT) Subject: Re: bug#47088: org-w3m: handle w3m-image link information To: emacs-orgmode@gnu.org References: <20210312062614.usandeuwplmn7fu3@E15-2016.optimum.net> <87zgx9ioi7.fsf@gnu.org> <20210506220515.fr7ebcvvtb3jj5yp@E15-2016.optimum.net> From: Nick Savage Message-ID: <0190f7aa-3656-dbac-2419-ac525426c909@nicksavage.ca> Date: Thu, 6 May 2021 19:56:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210506220515.fr7ebcvvtb3jj5yp@E15-2016.optimum.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: none client-ip=66.111.4.28; envelope-from=nick@nicksavage.ca; helo=out4-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620345429; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=cn35AZTfxo91VH0rwlr2sJ4eVRZHJHdWdrKSkJrSlzM=; b=EjaSACuUgwJK3ScmKdng+yyJ/eyxbMBpuhdswyRTBIox4XEZ0/vVp0lgbxdaBOGDEPxgMq 0z6HtAu6mb7RWyhUMR/2OHXcQorBYHxJAMtgyLPU+vQoq9h5+PfVvCHSFluOGTRkLi5zfY 4UgzLC2o256IBcncfmVYtoZgF7TiXEC78Y57M0qohQff6HIIlQSXYKmFH+mdr1XHDkwKGe md98CWrhMZDNjsVf7BnI5zHB9glPwAHFhjnfhq0Unl+3kYMmzMezaQYpBndFQrCjPDeO4z 5XNuWReMI2JPifx2A/t1NSvDsQmKIkCfYWTK4nEArMtlWNWbdL6QNMTKFo6s2A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620345429; a=rsa-sha256; cv=none; b=OQOplIl6bG9DiCy7FClE3TOdC3kWg5DtCh16nJV7exBMqftwJt/rWqawtKOO7g55v/CIy2 TKQjH23sYWqfWnHa0pWDylcdibVLgkmJ3cBEui1JuDbEJAXSqDcsSRpYucrZxtlmXS3Bbz z9sFEPN+TKT7kSnfO3Qv4TBvevF44Z4Y9HsPS1ReObC+KO2ioBTRSJqISoTew00dugSvyg yW2vGM+0qIj5AU5U5+MQPknRsO3hUmCVuUA6Sp9j5RnpOBIew/vDEqrz/n4QDszoLRkQWW dgp3zOdLLNDij6GpESRadmUiwD6oLfMO8chFNWKkdbyNWZ8X9OfVHk+NqXop8w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=PXqdejep; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.16 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=PXqdejep; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 0E4589C6F X-Spam-Score: -1.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: s0ELAMXGqt9C I haven't opened up the code yet to take a look, but I likely will take a crack at some of these items in the future as low-hanging fruit refactoring project. On 5/6/21 6:05 PM, Boruch Baum wrote: > (org-w3m-get-image-end): New function, for w3m-img links. > > 3] As mentioned in the patch, and in the commit message, there seem to > be several functioned unused in the code base that could be > candidates for removal... > > org-w3m-get-anchor-start > org-w3m-no-prev-link-p > org-w3m-get-prev-link-start > > 4] Additionally, in performing the merge I came across function > org-string-nw-p, which seems to be an unnecessary duplicate of the > emacs core function string-blank-p. It may be that historically you > once needed your own home-made functions/macros, but now that emacs > core has them, you may want to consider a refactor.