emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Raffael Stocker <r.stocker@mnet-mail.de>
To: emacs-orgmode@gnu.org
Subject: [BUG] Incorrect time calculation in agenda clockcheck
Date: Wed, 15 May 2024 15:34:01 +0200	[thread overview]
Message-ID: <yplmzfsrqjw6.fsf@mnet-mail.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]


Hi org-mode,

in the Org Agenda clockcheck view, a warning about missing end time of a
clocked-in task is displayed together with the already elapsed time of
that task.  If the starting time is in the future (this can happen if
rounding and continuous clocking are used), the elapsed time is
incorrect.  For example, if a clocked-in task starts in 5 minutes,
clockcheck will report something like "No end time: (0:55)".  It would
be more sensible to say "No end time: (-0:05)" or even "No end time: (in
0:05)".

The culprit is the use of ‘org-duration-from-minutes’ in
‘org-agenda-show-clocking-issues’, because org-duration always assumes
positive durations and is given a negative one here.  The problem can
easily be corrected with something like the following:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-agenda-primitive.patch --]
[-- Type: text/x-patch, Size: 863 bytes --]

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index b3c7294a2..968b6bd50 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -6237,11 +6237,12 @@ defun org-agenda-show-clocking-issues
 	      (setq issue
 		    (format
 		     "No end time: (%s)"
-		     (org-duration-from-minutes
-		      (floor
-		       (- (float-time (org-current-time))
-			  (float-time (org-time-string-to-time (match-string 1))))
-		       60)))
+		     (let ((diff (floor
+		                  (- (float-time (org-current-time))
+			             (float-time (org-time-string-to-time (match-string 1))))
+		                  60)))
+                       (concat (if (> 0 diff) "-" "")
+                               (org-duration-from-minutes (abs diff)))))
 		    face (or (plist-get pl :no-end-time-face) face))
 	      (throw 'next t))
 	    (setq ts (match-string 1)

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]


However, I believe it would be more useful (and general) to use a
similar trick to teach org-duration to work with negative durations.

Cheers,
Raffael

next             reply	other threads:[~2024-05-15 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 13:34 Raffael Stocker [this message]
2024-05-17 11:45 ` [BUG] Incorrect time calculation in agenda clockcheck Ihor Radchenko
2024-05-17 13:43   ` Mnet-Mail

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:b3c7294a dfblob:968b6bd5
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yplmzfsrqjw6.fsf@mnet-mail.de \
    --to=r.stocker@mnet-mail.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).