emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Importing "quoted" strings in `org-babel-import-elisp-from-file'
Date: Sat, 4 May 2024 21:55:44 +0700	[thread overview]
Message-ID: <v15i9g$aks$1@ciao.gmane.io> (raw)
In-Reply-To: <87edahyevc.fsf@localhost>

On 04/05/2024 18:51, Ihor Radchenko wrote:
> Max Nikulin writes:
>> Quotes are not stripped:
>>
>> (org-babel-read "\"abc\nsdf\"" t)
>> "\"abc
>> sdf\""
> 
> Fixed, on main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=edb5eaaac

Thanks

>> (org-babel-read "(\n\"abc\"\n" t)
>>
>> progn: End of file during parsing
> 
> I cannot reproduce. Still, I added a prophylactic measure to recover
> from parsing errors.

(should (equal "\"foo\"(\"bar\"" (org-babel-read "\"foo\"(\"bar\"" 
inhibit)))

you added to tests, does not cause the error since the unbalanced 
parenthesis is after first string. With the new regexp the error might 
happen for

(org-babel-read "\"Quoted closing quote:\\\"" t)

but it is caught by `ignore-errors'.

Perhaps `save-match-data' may be dropped if `string-match-p' is used 
instead of `string-match'. New code does not rely on match groups.

next prev parent reply	other threads:[~2024-05-04 14:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28 13:15 [BUG] ob-shell: results missing leading quotes Matt
2024-04-29 11:58 ` Ihor Radchenko
2024-05-01 10:48   ` Max Nikulin
2024-05-01 12:19     ` Importing "quoted" strings in `org-babel-import-elisp-from-file' (was: [BUG] ob-shell: results missing leading quotes) Ihor Radchenko
2024-05-02 17:56       ` Importing "quoted" strings in `org-babel-import-elisp-from-file' Max Nikulin
2024-05-03 12:06         ` Ihor Radchenko
2024-05-04  7:53           ` Max Nikulin
2024-05-04  8:03             ` Ihor Radchenko
2024-05-04 11:17               ` Max Nikulin
2024-05-04 11:51                 ` Ihor Radchenko
2024-05-04 14:55                   ` Max Nikulin [this message]
2024-05-04 19:34                     ` Ihor Radchenko
2024-05-04 15:58                   ` Max Nikulin
2024-05-04 19:35                     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='v15i9g$aks$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).